support for scoped registry urls #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://docs.npmjs.com/misc/scope#associating-a-scope-with-a-registry using node module rc to get the config (global and project specific) and use the registry url of the scope if existing, fallback to the official registry.npmjs.org
|
Hi! Thank you for the pull request and detailed explanation of how it works! Overall the approach of using of |
delfrrr
requested changes
Jun 28, 2018
lib/getPackageDetails.js
Outdated
| @@ -70,6 +72,11 @@ module.exports = function getPackageDetails( | |||
| return Promise.resolve(null); | |||
| } | |||
| const key = `${name}@${versionLoose}`; | |||
| const scope = (/(@[^\/]+)\/.*/.test(name) && /(@[^\/]+)\/.*/.exec(name)[1]) || ``; | |||
There was a problem hiding this comment.
I suggest to use https://github.com/npm/npm-package-arg (because npm uses it)
or alternatively copy logic from it to be on safe side 😉
this.scope = name[0] === '@' ? name.slice(0, name.indexOf('/')) : undefined
// scoped packages in couch must have slash url-encoded, e.g. @foo%2Fbar
this.escapedName = name.replace('/', '%2f')It's difficult to say if your regexp works exactly. the same.
There was a problem hiding this comment.
just changed the parsing to the same logic, thanks for the hint
lib/getPackageDetails.js
Outdated
| var registryUrl = (scope && npmConfig[`${scope}:registry`]) || npmConfig[`registry`]; | ||
| if(registryUrl.charAt(registryUrl.length - 1) !== `/`) { | ||
| registryUrl += `/`; | ||
| } |
lib/getPackageDetails.js
Outdated
| @@ -70,6 +72,11 @@ module.exports = function getPackageDetails( | |||
| return Promise.resolve(null); | |||
| } | |||
| const key = `${name}@${versionLoose}`; | |||
| const scope = (/(@[^\/]+)\/.*/.test(name) && /(@[^\/]+)\/.*/.exec(name)[1]) || ``; | |||
| var registryUrl = (scope && npmConfig[`${scope}:registry`]) || npmConfig[`registry`]; | |||
There was a problem hiding this comment.
fixed together with the remaining eslint errors
delfrrr
approved these changes
Jun 30, 2018
|
Thank you @killerfurbel ! |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got across this when checking one of my projects which contains modules from SAP (@sap/ prefix), those modules are hosted on npm.sap.com. To be able to
npm installthose modules, you need to add this setting to the npm config (for example, to the user config):@sap:registry = "https://npm.sap.com"see https://docs.npmjs.com/misc/scope#associating-a-scope-with-a-registry
I was looking for a way to get these npm settings and came across npm-conf, but this module mainly relied on a dependency config-chain to get the configuration. I checked this one and it said:
So I went with rc, which does the job.
rc has the following dependencies:
Now rc is used to get the config (global and project specific), the module key is checked for a scope using a regex (starting with @, containing a /). If there is a scope, try to use the registry url of the scope, fallback to the official registry.npmjs.org
npm config is fine when the scoped registry URL does not end with a /, but since we just concaternate the module name, we need to add a / to the url if it doesn't end with one...